enhance entering, exiting, and copying in copy mode#79
Closed
BrettKulp wants to merge 3 commits intoleohenon:ocvfrom
Closed
enhance entering, exiting, and copying in copy mode#79BrettKulp wants to merge 3 commits intoleohenon:ocvfrom
BrettKulp wants to merge 3 commits intoleohenon:ocvfrom
Conversation
Owner
|
Thanks! Would you mind splitting copy mode |
Author
|
I sent the yy pr #82 did you want me to make a new pr with these changes that does not include yy? |
Owner
|
Yes please, remove the |
BrettKulp
force-pushed
the
feature/enhance_copy_mode
branch
from
e126afd to
b6380b9
Compare
BrettKulp
force-pushed
the
feature/enhance_copy_mode
branch
from
ace54bb to
2d9b0b2
Compare
Owner
|
Thanks. Can you explain why both |
Author
|
exitScrollToBottom was redundant. I removed it but I just noticed some flashing on long chats that is happening |
Author
|
I will reopen this when I fix the flashing. It is turning out to be harder to fix than I expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is where I ended up with #50
add ctrl + w j/k for entering and exiting copy mode without scrolling the chat history. The cursor will enter into a row that is already visible in the chat history if the chat is scrolled up to previous older messages. Leader + v, esc, and q still scroll chat history while entering and exiting as before.
add yy for yanking a whole line in copy mode while not in VL mode
add i going directly into insert mode in the input prompt without scrolling the chat history
make it so y in copy mode stays in copy mode rather than scrolls the chat history to the bottom
Entering and exiting copy mode via ctr + w + j/k if will enter into a visible section of chat history
I like these changes because they feel more like vim to me but if you don't want to force them onto users I understand